Expose the validate_motion function and the robot’s lower and upper bounds to Python. #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claytonwramsey
approved these changes
Dec 12, 2025
Member
claytonwramsey
left a comment
claytonwramsey
left a comment
There was a problem hiding this comment.
note my one comment but otherwise ok! good to submit when that is done.
|
|
||
| const bool in_bounds_out = (copy_out <= 1.F).all() and (copy_out >= 0.F).all(); | ||
|
|
||
| return (not check_bounds or in_bounds_in or in_bounds_out) and |
Member
There was a problem hiding this comment.
should this be (not check_bounds or (in_bounds_in and in_bounds_out))? Since if we are checking the bounds, we want both ends of the transition to be valid.
Also, maybe we should move the calculation of in_bounds_in and in_bounds_out to be gated behind an if statement to save perf where check_bounds is false? It is not a big loss though, so this is probably fine as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.