Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes a possible data race of the underlying BTree since it can contain shared reference-type BtreeNodes
Note
Converts
Index.ComparableValueto a locked reference model to prevent BTree data races, addsEntityRefModelmacro and wiring, and bumps macOS minimum to 13.Index.ComparableValuefrom@EntityModelstruct to@EntityRefModelfinal class and mark@unchecked Sendable.OSAllocatedUnfairLockand wrap reads/writes (sorted,filter,contains,grouped,update,remove) with lock; move mutating internals to private_helpers.EntityRefModelmacro and register inMacros.swiftandMacrosPlugin.EntityModelMacroto handle classes by generatingentityRefModelProtocoland nonmutatingnormalize(); add supporting codegen helpers.v13.Written by Cursor Bugbot for commit 003905b. This will update automatically on new commits. Configure here.