iOS versions compatibility fix #104
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on January 18
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
|
|
||
| let name: String | ||
| private let lock = OSAllocatedUnfairLock() | ||
| private let lock = NSLock() |
There was a problem hiding this comment.
Bug: NSLock.withLock unavailable on older iOS versions
The compatibility fix replaces OSAllocatedUnfairLock with NSLock, but the code still uses lock.withLock { } throughout the file. The withLock method on NSLocking was introduced in iOS 16/macOS 13 - the same versions that OSAllocatedUnfairLock requires. Since the Package.swift targets iOS 12, this change doesn't actually achieve the intended backward compatibility. To support older iOS versions, the code would need to use lock() / unlock() manually instead of withLock.
There was a problem hiding this comment.
NSLock.withLock { ... } is available since iOS 8.0. AI is cooked ahahaha
PR fix compatibility with older iOS versions
Note
Replace OSAllocatedUnfairLock with NSLock in Index.ComparableValue to maintain compatibility with older iOS versions.
OSAllocatedUnfairLockwithNSLockinIndex.ComparableValuefor wider iOS compatibility.Written by Cursor Bugbot for commit 7636e24. This will update automatically on new commits. Configure here.