Skip to content

Allow Symfony 3.x - #137

Closed
enumag wants to merge 3 commits into
Kdyby:masterfrom
enumag:patch-4
Closed

Allow Symfony 3.x#137
enumag wants to merge 3 commits into
Kdyby:masterfrom
enumag:patch-4

Conversation

@enumag

@enumag enumag commented Mar 18, 2017 •
edited by fprochazka
Loading

Copy link
Copy Markdown
Member

[Closes #118]

@coveralls

coveralls commented Mar 18, 2017

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-35.6%) to 34.532% when pulling 9612491 on enumag:patch-4 into 14ddd26 on Kdyby:master.

@coveralls

coveralls commented Mar 18, 2017

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-3.8%) to 66.315% when pulling 73a1548 on enumag:patch-4 into 14ddd26 on Kdyby:master.

@coveralls

coveralls commented Mar 18, 2017

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.08%) to 70.047% when pulling c2bc948 on enumag:patch-4 into 14ddd26 on Kdyby:master.

@enumag

enumag commented Mar 18, 2017

Copy link
Copy Markdown
Member Author

@fprochazka The failing test is the same one as in master so it's unrelated to this pull request.

@coveralls

coveralls commented Mar 18, 2017

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.08%) to 70.047% when pulling 2b56ca6 on enumag:patch-4 into 14ddd26 on Kdyby:master.

@aleswita

aleswita commented Mar 21, 2017 •
edited
Loading

Copy link
Copy Markdown

It's posibble to add dependency on nette/php-generator ~3.0.0 to this pull request?

@enumag

enumag commented Mar 21, 2017

Copy link
Copy Markdown
Member Author

@aleswita That should be a separate PR in my opinion. Feel free to send one.

@fprochazka fprochazka added this to the v2.3 milestone May 15, 2017
@fprochazka fprochazka mentioned this pull request May 15, 2017
Closed
fprochazka pushed a commit that referenced this pull request May 15, 2017
@enumag @fprochazka
Allow Symfony 3.x
950d470 
Fix NeonFileDumper
Fix Translator

[Closes #137] [Closes #118]
@fprochazka

fprochazka commented May 15, 2017

Copy link
Copy Markdown
Member

@enumag Thank you!

@fprochazka

fprochazka commented May 15, 2017

Copy link
Copy Markdown
Member

@aleswita added 0400e8b :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

v2.3

Development

Successfully merging this pull request may close these issues.

4 participants

@enumag @coveralls @aleswita @fprochazka