Add support for inheritance in neon translation files - #140
Open
Olicek wants to merge 1 commit into
Open
Conversation
Author
|
Tomorrow i will try to repair tests and remove forgotten PHP7 syntax |
Author
|
I have absolutly no idea how to fix tests. I have exactly same code in my application and it works properly... |
|
Duplicate the tests. One with include, expecting overriding message and one without include, expecting default message. Now are tested both original and included texts but original one not outputted because of override. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't know, if i write tests properly. Everything else shlould works fine.