Skip to content

untranslated callback, monolog integration #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rattuscz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

untranslated callback, monolog integration #81

rattuscz wants to merge 1 commit into from

Conversation

@rattuscz
Copy link

@rattuscz rattuscz commented Jun 30, 2015

response to #80

My first attempt at extension so please feel free to criticize

fprochazka
fprochazka reviewed Jun 30, 2015
View reviewed changes
src/Kdyby/Translation/DI/TranslationExtension.php
Copy link
Member

@fprochazka fprochazka Jun 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather depend on the PSR interface than on monolog.

@fprochazka
Copy link
Member

fprochazka commented Jun 30, 2015

I might have told you a wrong way to solve this, should have thought about it more before I wrote it in the issue. I'm not sure I like this.
But apart from the coding style issues, you've done a good job! Let me just think about this for a bit.

@fprochazka fprochazka added this to the v3.0 milestone May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

v3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@rattuscz @fprochazka