prevent symfony/validator v5 from installing

[PavelJurasek]

Version 5 was released 5 days ago (https://github.com/symfony/validator/releases) and breaks this package with error Nette\DI\ServiceCreationException: Class Symfony\Component\Validator\Mapping\Cache\DoctrineCache used in service 'validator.cache' not found.

Thanks for merge and release of new version.

[PavelJurasek]

ping @enumag just in case you don't receive notifications on new PRs :)

[PavelJurasek]

oops, this version restriction might not be enough.

[enumag]

Hmm... what's the proper fix to make this package v5 compatible? (I don't really use Nette or Symfony too much these days.)

And thanks for the ping. I indeed don't get notifications otherwise.

[PavelJurasek]

Forcepushed change with restriction to <4.4 (4.4 causes method signature incompatibility)

Honestly, I didn't investigate the incompatible changes now since I depend on 3rd party package using this package and I just need to get my app running 😇

[Majkl578]

(4.4 causes method signature incompatibility)

Could you provide upstream issue about this BC break?

[enumag]

I just need to get my app running

You can always do that by adding a conflict with SF validator 4.4+ or adding a dependency on SF validator 4.3.

[PavelJurasek]

@Majkl578 it's caused by symfony/translation-contracts being installed at version 2.0 if symfony/validator v4.4 is installed. where should I report it? In validator repository?

Declaration of Symfony\Component\Translation\TranslatorInterface::setLocale($locale) must be compatible with Symfony\Contracts\Translation\LocaleAwareInterface::setLocale(string $locale)

@enumag sure, I did that :)

[enumag]

All issues should be reported in symfony/symfony. This looks like symfony/translation doesn't have correct version constraint for symfony/translation-contracts maybe.