Applying Java 17 refactorings#3252
Merged
Merged
Conversation
wadoon
added
the
🛠 Maintenance
Codecov Report
@@ Coverage Diff @@
## main #3252 +/- ##
============================================
- Coverage 37.75% 37.73% -0.02%
+ Complexity 16872 16851 -21
============================================
Files 2053 2052 -1
Lines 126504 125687 -817
Branches 21263 21234 -29
============================================
- Hits 47764 47432 -332
+ Misses 72893 72412 -481
+ Partials 5847 5843 -4
... and 98 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
if( obj instance C) {
var c = (C) obj);
...
}
becomes:
if( obj instance C c) {
...
}
* apply intellij refactoring for records * some minor fixes like wrong methods in javadoc
wadoon
force-pushed
the
weigl/java17-cleanup
branch
from
cbf036a to
69c3516
Compare
wadoon
force-pushed
the
weigl/java17-cleanup
branch
from
69c3516 to
8dd8db2
Compare
…ssing space in instanceof formatting
Member
|
The missing space when using instanceof (e.g. However, I had to fix the formatter version to 4.22, since more recent versions have another bug, such that it crashes while trying to format our |
WolframPfeifer
approved these changes
Aug 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies refactorings after the switch to Java 17 for after #3241.
Including:
instanceofand casts to Pattern expressions.toList()instead of.collect(Collectors.toList)""" ... """) on large strings instead of concatenation cascades.