Skip to content

Further Refactorings for Java 17+#3264

Merged
wadoon merged 5 commits into
mainfrom
weigl/java17refact
Oct 12, 2023
Merged

Further Refactorings for Java 17+#3264
wadoon merged 5 commits into
mainfrom
weigl/java17refact

Conversation

@wadoon
Copy link
Copy Markdown
Member

@wadoon wadoon commented Aug 27, 2023

Refactoring and Code clean up.

  • switch statements into switch expression where it was useful.
    (avoids fall throughs and often more compact code)

  • some smaller (non-structured) clean ups

    • ensure camel cases variable names
    • fix Javadoc
    • and other code smells recognize by IntelliJ

@wadoon wadoon added the 🛠 Maintenance Code quality and related things w/o functional changes label Aug 27, 2023
@wadoon wadoon self-assigned this Aug 27, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 27, 2023

Codecov Report

Merging #3264 (5e9bddf) into main (a2d4fe7) will increase coverage by 0.02%.
Report is 3 commits behind head on main.
The diff coverage is 26.87%.

@@             Coverage Diff              @@
##               main    #3264      +/-   ##
============================================
+ Coverage     37.76%   37.78%   +0.02%     
+ Complexity    16863    16850      -13     
============================================
  Files          2052     2052              
  Lines        125687   125399     -288     
  Branches      21234    21218      -16     
============================================
- Hits          47464    47387      -77     
+ Misses        72389    72178     -211     
  Partials       5834     5834              
Files Changed Coverage Δ
...e/uka/ilkd/key/testgen/ReflectionClassCreator.java 0.00% <0.00%> (ø)
...e/uka/ilkd/key/testgen/oracle/OracleGenerator.java 0.00% <0.00%> (ø)
...ain/java/de/uka/ilkd/key/java/CompilationUnit.java 12.28% <ø> (+0.61%) ⬆️
.../src/main/java/de/uka/ilkd/key/java/JavaTools.java 80.00% <ø> (-0.96%) ⬇️
.../uka/ilkd/key/java/SchemaRecoder2KeYConverter.java 85.27% <ø> (-0.23%) ⬇️
...d/key/java/expression/ParenthesizedExpression.java 35.71% <ø> (+2.38%) ⬆️
...ka/ilkd/key/java/recoderext/ExecCtxtSVWrapper.java 55.55% <ø> (-4.45%) ⬇️
.../ilkd/key/java/recoderext/ExpressionSVWrapper.java 45.83% <ø> (-0.60%) ⬇️
...d/key/java/recoderext/SpecialReferenceWrapper.java 0.00% <ø> (ø)
...de/uka/ilkd/key/java/recoderext/adt/Intersect.java 100.00% <ø> (+10.00%) ⬆️
... and 68 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 27, 2023

Thank you for your contribution.

The test artifacts are available on Artiweb.
The newest artifact is here.

@wadoon wadoon added this to the v2.14.0 milestone Aug 29, 2023
@wadoon wadoon marked this pull request as ready for review September 22, 2023 17:14
@wadoon wadoon requested review from Drodt and removed request for WolframPfeifer September 29, 2023 13:36
@wadoon wadoon added 🐞 Bug and removed 🐞 Bug labels Sep 29, 2023
@wadoon wadoon added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit e5a80d4 Oct 12, 2023
@wadoon wadoon deleted the weigl/java17refact branch October 12, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🛠 Maintenance Code quality and related things w/o functional changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants