Backport of KEY-2.12.1 into main#3296
Merged
Merged
Conversation
* key.core:rifl was moved to key.core.rifl (toplevel) due to project naming on Maven Central
This is to prevent multiple clicks on the button, and to provide some visual feedback that the stop is in progress.
Might be added again later if we agree on its usefulness.
wadoon
force-pushed
the
weigl/backport2121
branch
from
05635af to
cfbb1e1
Compare
Codecov Report
@@ Coverage Diff @@
## main #3296 +/- ##
============================================
+ Coverage 37.78% 37.81% +0.02%
Complexity 16851 16851
============================================
Files 2052 2052
Lines 125409 125485 +76
Branches 21220 21228 +8
============================================
+ Hits 47386 47448 +62
- Misses 72187 72196 +9
- Partials 5836 5841 +5
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
WolframPfeifer
approved these changes
Oct 13, 2023
Member
WolframPfeifer
left a comment
WolframPfeifer
left a comment
There was a problem hiding this comment.
Maybe we should revert the version number change (see my suggestion), or would it be better to have a separate commit/PR on main?
Co-authored-by: Wolfram Pfeifer <94171076+WolframPfeifer@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backporting the bug fixes in KEY-2.12.1 to main. This PR supersedes #3251 to avoid merge conflicts due to file header changes. Necessary changes were cherry-picked.