Nicer error message for parse errors#3417
Merged
5 commits merged intoApr 15, 2024
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3417 +/- ##
============================================
+ Coverage 37.77% 37.78% +0.01%
- Complexity 17031 17037 +6
============================================
Files 2076 2076
Lines 126950 126992 +42
Branches 21381 21387 +6
============================================
+ Hits 47952 47981 +29
- Misses 73092 73102 +10
- Partials 5906 5909 +3 ☔ View full report in Codecov by Sentry. |
Contributor
|
\rules { \problem { true } |
Member
Author
|
I added another case that handles your problematic input. |
7254776
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended Change
#3406 leads to user-facing ParseCancellationExceptions, which are not debuggable. This PR enhances the user experience by actually showing the error in the context of the input file, and listing the found token and the expected token types. Previously, only the class name of the exception was displayed.
Type of pull request
Ensuring quality
missing_semicolon.keyAdditional information and contact(s)
The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.