-
Notifications
You must be signed in to change notification settings - Fork 304
Allow sort filter to be case insensitive #967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thank you so much for writing this patch—I've been looking for this functionality for ages but haven't had the time to implement something myself! Hope this gets merged soon. |
@Keats Just wanted to follow up to see what your ideas for resolving the MSRV test failing so that we can get this merged and brought upstream to Zola ^_^ |
I think it's fine to merge as is and change the MSRV after merge. |
I might have some time to work on it this month — are there any quirks or other things I might need to know about with the new version ? |
It should be easier to implement, they look more like regular functions. For example: https://github.com/Keats/tera2/blob/master/tera/src/filters.rs#L322-L341 |
Since the round topic has been touched upon, I will make my suggestions regarding this filter. It would be logical to add the trunc method.
|
Sure that can be added |
I saw it was proper ages ago that someone tried bringing case sensitivity to the
sort
filter and figured I'd go at it. If I'm not mistaken, Tera will use case sensitivity by default (that is, prior to and after this PR) so I only added a test for case insensitivity.Closes #587
Closes #831
See also : #693