Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR switches the CI runners from QEMU-based emulation to native Linux/aarch64 runners to improve build times. Key changes include updating the Docker images and GitHub host names for various target configurations, refactoring architecture computation functions, and adjusting the CI workflow steps in .github/workflows/CI.yml to support the new native runners.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| utils/create-ci-workflow | Updates to target configuration, Docker image references, and refactored architecture computation. |
| .github/workflows/CI.yml | Modifications to CI job definitions including updated Docker image/platform values and shell changes. |
Comments suppressed due to low confidence (2)
utils/create-ci-workflow:606
- Consider adding a TODO comment indicating that Rust installation in Docker is pending implementation so that future maintainers know this is an intentional placeholder rather than an oversight.
throw(new Error(`Need to install Rust in Docker image -- not implemented ${target}`));
.github/workflows/CI.yml:245
- Since the shell was changed from bash to sh, please verify that all build commands—especially those involving complex shell expansions—are fully compatible with sh to avoid unexpected runtime issues.
shell: sh
|
|
This change aims to improve build times by switching away from QEMU to native Linux/aarch64 build runners.