fix(audio): fix SDL backend buffer sizing issues causing audio cuts/glitches when CPU is struggling#1107
Open
bassdr wants to merge 1 commit into
Open
fix(audio): fix SDL backend buffer sizing issues causing audio cuts/glitches when CPU is struggling#1107bassdr wants to merge 1 commit into
bassdr wants to merge 1 commit into
Conversation
…CPU is struggling - Use SDL_InitSubSystem(SDL_INIT_AUDIO) instead of SDL_Init() to avoid reinitializing unrelated SDL subsystems - Double the hardware buffer size (SampleLength * 2) to reduce backend underruns without affecting emulator buffering logic - Remove the hardcoded 6000-frame fill guard in DoPlay(); the guard was an arbitrary threshold that caused audio starvation on slow frames. SDL's internal queue handles backpressure naturally - Read actual channel count from SDL's 'have' spec instead of assuming the requested value was honored - Minor: NULL → nullptr, coding style cleanup, improved log format
bassdr
changed the title
bassdr
changed the title
briaguya0
reviewed
May 19, 2026
briaguya0
approved these changes
May 22, 2026
This was referenced May 22, 2026
This was referenced Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.