Skip to content

Fix NullAudioPlayer::Buffered() returning 0 (audio-thread spin/hang) #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bassdr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix NullAudioPlayer::Buffered() returning 0 (audio-thread spin/hang) #1129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/ship/audio/NullAudioPlayer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ void NullAudioPlayer::DoClose() {
}

int NullAudioPlayer::Buffered() {
return 0;
// Report the device as always full; it discards all audio, so returning the
// true count (0) makes the producer spin feeding it forever and hang.
return GetDesiredBuffered();
}

void NullAudioPlayer::DoPlay(const uint8_t* buf, size_t len) {
Expand Down
Loading