-
Notifications
You must be signed in to change notification settings - Fork 189
Fix missing rumble/LED/gyro for PS4/PS5 controllers over Bluetooth #1133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,6 +24,10 @@ int32_t osContInit(OSMesgQueue* mq, uint8_t* controllerBits, OSContStatus* statu | |
| } | ||
|
|
||
| SDL_SetHint(SDL_HINT_JOYSTICK_THREAD, "1"); | ||
| SDL_SetHint(SDL_HINT_JOYSTICK_HIDAPI_PS4, "1"); | ||
| SDL_SetHint(SDL_HINT_JOYSTICK_HIDAPI_PS4_RUMBLE, "1"); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This doesn't come without side-effects from https://wiki.libsdl.org/SDL2/SDL_HINT_JOYSTICK_HIDAPI_PS4_RUMBLE
|
||
| SDL_SetHint(SDL_HINT_JOYSTICK_HIDAPI_PS5, "1"); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same as from https://wiki.libsdl.org/SDL2/SDL_HINT_JOYSTICK_HIDAPI_PS5
|
||
| SDL_SetHint(SDL_HINT_JOYSTICK_HIDAPI_PS5_RUMBLE, "1"); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same as |
||
| if (SDL_Init(SDL_INIT_GAMECONTROLLER) != 0) { | ||
| SPDLOG_ERROR("Failed to initialize SDL game controllers ({})", SDL_GetError()); | ||
| exit(EXIT_FAILURE); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should already be set
from https://wiki.libsdl.org/SDL2/SDL_HINT_JOYSTICK_HIDAPI_PS4
from https://wiki.libsdl.org/SDL2/SDL_HINT_JOYSTICK_HIDAPI