macOS: prefer package-manager SDL2 over a stale system framework#1134
Open
quarrel07 wants to merge 1 commit into
Open
macOS: prefer package-manager SDL2 over a stale system framework#1134quarrel07 wants to merge 1 commit into
quarrel07 wants to merge 1 commit into
Conversation
A stale or partial /Library/Frameworks/SDL2.framework (left by some installers)
shadows a working Homebrew/MacPorts SDL2 and breaks configuration:
File or directory /Library/Headers referenced by variable
SDL2_INCLUDE_DIR does not exist !
The framework's bundled CMake config sets SDL2_INCLUDE_DIR to a non-existent
/Library/Headers, so find_package(SDL2 REQUIRED) fails even though a working
SDL2 is installed via Homebrew/MacPorts.
Set CMAKE_FIND_FRAMEWORK LAST so package-manager installs win, and add the
Homebrew prefix to CMAKE_PREFIX_PATH so SDL2's CMake config is found without
requiring the user to pass -DSDL2_DIR manually. Only affects the macOS path.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On macOS, a stale or partial
/Library/Frameworks/SDL2.framework(left behind by some installers) shadows a working Homebrew/MacPorts SDL2 and breaks configuration:The framework's bundled CMake config sets
SDL2_INCLUDE_DIRto a non-existent/Library/Headers, sofind_package(SDL2 REQUIRED)fails even though a perfectly good SDL2 is installed via Homebrew. The only current workaround is to pass-DSDL2_DIR=...(or delete the system framework) manually.Fix
In
cmake/dependencies/mac.cmake, search frameworks last and add the Homebrew prefix to the search path, so the package-manager SDL2 (and its CMake config) is preferred automatically:Scoped to the macOS dependency path; no effect on other platforms. One file changed; branched off current
main.