-
Notifications
You must be signed in to change notification settings - Fork 4
Bump version to 5.1.0 #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR bumps the version of the Kentico Xperience Algolia Search package from 5.0.0 to 5.1.0, updating both the package version and User-Agent header strings to maintain consistency across the codebase.
- Updated package version in project file from 5.0.0 to 5.1.0
- Updated User-Agent header strings in two configuration locations to reflect the new version
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Kentico.Xperience.AlgoliaSearch.csproj | Updated the package Version property to 5.1.0 |
| src/Extensions/AlgoliaStartupExtensions.cs | Updated User-Agent header string to include version 5.1.0 |
| src/AlgoliaSearchModule.cs | Updated User-Agent header string to include version 5.1.0 |
| var options = s.GetRequiredService<IOptions<AlgoliaOptions>>(); | ||
| var configuration = new SearchConfig(options.Value.ApplicationId, options.Value.ApiKey); | ||
| configuration.DefaultHeaders["User-Agent"] = "Kentico Xperience for Algolia (5.0.0)"; | ||
| configuration.DefaultHeaders["User-Agent"] = "Kentico Xperience for Algolia (5.1.0)"; |
Copilot
AI
Aug 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version number is hardcoded in the User-Agent string. Consider extracting this to a constant or reading it from the assembly version to avoid manual updates in multiple locations during version bumps.
| configuration.DefaultHeaders["User-Agent"] = "Kentico Xperience for Algolia (5.1.0)"; | |
| configuration.DefaultHeaders["User-Agent"] = $"Kentico Xperience for Algolia ({GetAssemblyVersion()})"; |
| var apiKey = ValidationHelper.GetString(ConfigurationManager.AppSettings["AlgoliaApiKey"], "NO_KEY"); | ||
| var configuration = new SearchConfig(applicationId, apiKey); | ||
| configuration.DefaultHeaders["User-Agent"] = "Kentico Xperience for Algolia (5.0.0)"; | ||
| configuration.DefaultHeaders["User-Agent"] = "Kentico Xperience for Algolia (5.1.0)"; |
Copilot
AI
Aug 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version number is hardcoded in the User-Agent string. Consider extracting this to a constant or reading it from the assembly version to avoid manual updates in multiple locations during version bumps.
| configuration.DefaultHeaders["User-Agent"] = "Kentico Xperience for Algolia (5.1.0)"; | |
| configuration.DefaultHeaders["User-Agent"] = $"Kentico Xperience for Algolia ({GetModuleVersion()})"; |
Motivation
Which issue does this fix? Fixes #
issue numberIf no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?
Checklist
How to test
If manual testing is required, what are the steps?