Release v3.4.0 #407
Merged
Release v3.4.0 #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…primary key Fix: Fix custom class mapping for classes with just reusables schemas and primary key
Fix custom class mapping for classes with just reusables schemas and primary key
DOCS: Migrate pages to widgets
Upgrade: Upgrade to XbyK 30.4.0
Upgrade to XbyK 30.4.0
Chore: Fix formatting
Fix formatting
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR prepares the v3.4.0 release by introducing several enhancements and improvements related to form field patching, reusable schema management, and migration documentation. Key changes include:
- Adding an optional excludedFields parameter to PatchFields in the CmsClass patcher.
- Updating README documentation to describe page-to-widget migration functionality.
- Modifying methods in ReusableSchemaService, ClassMappingProvider, and CmsClassMapper to return and propagate schema GUIDs, and updating legacy field mapping.
Reviewed Changes
Copilot reviewed 7 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Migration.Tool.KXP.Api/Services/CmsClass/FormDefinitionPatcher.cs | Introduces an optional excludedFields parameter to skip specified fields during patching. |
| Migration.Tool.Extensions/README.md | Adds documentation for page-to-widget migrations. |
| Migration.Tool.CLI/README.md | Updates CLI README to mention the new custom migrations for widget content. |
| KVA/Migration.Tool.Source/Services/ReusableSchemaService.cs | Changes AddReusableSchemaToDataClass to return the schema GUID. |
| KVA/Migration.Tool.Source/Providers/ClassMappingProvider.cs | Adds reusableSchemas tracking and a helper method for retrieving form element names. |
| KVA/Migration.Tool.Source/Mappers/CmsClassMapper.cs | Updates PatchDataClassInfo and legacy field mapping to leverage the new reusableSchemas dictionary. |
| KVA/Migration.Tool.Source/Helpers/FormDefinitionHelper.cs | Updates MapFormDefinitionFields to pass excluded fields to the patcher. |
Files not reviewed (3)
- Migration.Tool.Common/Migration.Tool.Common.csproj: Language not supported
- Migration.Tool.KXP.Api/Migration.Tool.KXP.Api.csproj: Language not supported
- Migration.Tool.KXP.Extensions/Migration.Tool.KXP.Extensions.csproj: Language not supported
Comments suppressed due to low confidence (1)
KVA/Migration.Tool.Source/Mappers/CmsClassMapper.cs:359
- [nitpick] Consider using ToLowerInvariant() instead of ToLower() to ensure consistent behavior regardless of the current culture.
Guid = GuidHelper.CreateFieldGuid("${mapping.LegacyFieldName.ToLower()}|${newClassName}"),
michalJakubis
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release v3.4.0