Fix ConfigurationValidator incorrectly validating non-existent Commer…

Migration.Tool.CLI/ConfigurationValidator.cs

@@ -161,7 +161,7 @@ public static IEnumerable<ValidationMessage> GetValidationErrors(IConfigurationR
         #region Commerce configuration validation
 
         var commerceConfiguration = settings?.GetSection(ConfigurationNames.CommerceConfiguration);
-        if (commerceConfiguration is not null)
+        if (commerceConfiguration?.Exists() == true)
         {
             var commerceSiteNames = commerceConfiguration.GetSection(ConfigurationNames.CommerceSiteNames).Get<List<string>?>();
             if (commerceSiteNames is null || commerceSiteNames.Count == 0)

Migration.Tool.Tests/ConfigurationValidatorTests.cs

@@ -0,0 +1,73 @@
+using Microsoft.Extensions.Configuration;
+using Migration.Tool.CLI;
+
+namespace Migration.Tool.Tests;
+
+public class ConfigurationValidatorTests
+{
+    [Fact]
+    public void GetValidationErrors_WhenCommerceConfigurationSectionDoesNotExist_ShouldNotReturnValidationErrors()
+    {
+        // Arrange - Create configuration without CommerceConfiguration section
+        var configuration = new ConfigurationBuilder()
+            .AddInMemoryCollection(new Dictionary<string, string?>
+            {
+                ["Settings:KxConnectionString"] = "Server=localhost;Database=Kentico;",
+                ["Settings:XbyKDirPath"] = "C:\\XbyK",
+                ["Settings:XbyKApiSettings:ConnectionStrings:CMSConnectionString"] = "Server=localhost;Database=XbyK;"
+            })
+            .Build();
+
+        // Act
+        var errors = ConfigurationValidator.GetValidationErrors(configuration).ToList();
+
+        // Assert - Should not contain CommerceConfiguration validation error
+        Assert.DoesNotContain(errors, e => e.Message.Contains("CommerceConfiguration"));
+    }
+
+    [Fact]
+    public void GetValidationErrors_WhenCommerceConfigurationExistsWithEmptySiteNames_ShouldReturnValidationError()
+    {
+        // Arrange - Create configuration with CommerceConfiguration section containing empty site name
+        var configuration = new ConfigurationBuilder()
+            .AddInMemoryCollection(new Dictionary<string, string?>
+            {
+                ["Settings:KxConnectionString"] = "Server=localhost;Database=Kentico;",
+                ["Settings:XbyKDirPath"] = "C:\\XbyK",
+                ["Settings:XbyKApiSettings:ConnectionStrings:CMSConnectionString"] = "Server=localhost;Database=XbyK;",
+                ["Settings:CommerceConfiguration:CommerceSiteNames:0"] = "" // Empty value
+            })
+            .Build();
+
+        // Act
+        var errors = ConfigurationValidator.GetValidationErrors(configuration).ToList();
+
+        // Assert - Should contain validation error for empty site names
+        Assert.Contains(errors, e => e.Message.Contains("CommerceConfiguration:CommerceSiteNames") &&
+                                     e.Message.Contains("cannot contain empty or whitespace values"));
+    }
+
+    [Fact]
+    public void GetValidationErrors_WhenCommerceConfigurationExistsWithValidSiteNames_ShouldNotReturnCommerceValidationErrors()
+    {
+        // Arrange - Create configuration with valid CommerceConfiguration
+        var configuration = new ConfigurationBuilder()
+            .AddInMemoryCollection(new Dictionary<string, string?>
+            {
+                ["Settings:KxConnectionString"] = "Server=localhost;Database=Kentico;",
+                ["Settings:XbyKDirPath"] = "C:\\XbyK",
+                ["Settings:XbyKApiSettings:ConnectionStrings:CMSConnectionString"] = "Server=localhost;Database=XbyK;",
+                ["Settings:CommerceConfiguration:CommerceSiteNames:0"] = "MySite"
+            })
+            .Build();
+
+        // Act
+        var errors = ConfigurationValidator.GetValidationErrors(configuration).ToList();
+
+        // Assert - Should not contain CommerceConfiguration validation errors
+        Assert.DoesNotContain(errors, e => e.Message.Contains("CommerceConfiguration:CommerceSiteNames") &&
+                                           e.Message.Contains("must contain at least one site name"));
+        Assert.DoesNotContain(errors, e => e.Message.Contains("CommerceConfiguration:CommerceSiteNames") &&
+                                           e.Message.Contains("cannot contain empty or whitespace values"));
+    }
+}

Migration.Tool.Tests/Migration.Tool.Tests.csproj

@@ -19,6 +19,7 @@
 
     <ItemGroup>
         <ProjectReference Include="..\Migration.Tool.Common\Migration.Tool.Common.csproj" />
+        <ProjectReference Include="..\Migration.Tool.CLI\Migration.Tool.CLI.csproj" />
     </ItemGroup>
 
 </Project>

README.md

@@ -129,27 +129,25 @@ To understand when and how to implement customizations:
 View all [project releases](https://github.com/Kentico/xperience-by-kentico-kentico-migration-tool/releases/).
 
 | Xperience Version | Library Version |
-| ----------------- | --------------- |
-| 31.0.0            | 4.1.0           |
-| 31.0.0            | 4.0.0           |
-| 30.12.0           | 3.21.0          |
-| 30.12.0           | 3.20.0          |
-| 30.11.0           | 3.18.0          |
-| 30.10.1           | 3.16.0          |
-| 30.8.0            | 3.12.0          |
-| 30.6.0            | 3.8.0           |
-| 30.5.1            | 3.6.0           |
-| 30.4.0            | 3.4.0           |
-| 30.3.1            | 3.3.0           |
-| 30.2.0            | 3.0.0           |
-| 30.1.1            | 2.3.0           |
-| 30.0.0            | 2.0.0           |
-| 29.7.0            | 1.6.0           |
-| 29.6.0            | 1.4.0           |
-| 29.5.2            | 1.3.0           |
-| 29.3.3            | 1.2.0           |
-| 29.2.0            | 1.1.0           |
-| 29.1.0            | 1.0.0           |
+| ------------------| ----------------|
+| >= 31.0.0         | >= 4.0.0        |
+| >= 30.12.0        | >= 3.20.0       |
+| >= 30.11.0        | >= 3.18.0       |
+| >= 30.10.1        | >= 3.16.0       |
+| >= 30.8.0         | >= 3.12.0       |
+| >= 30.6.0         | >= 3.8.0        |
+| >= 30.5.1         | >= 3.6.0        |
+| >= 30.4.0         | >= 3.4.0        |
+| >= 30.3.1         | >= 3.3.0        |
+| >= 30.2.0         | >= 3.0.0        |
+| >= 30.1.1         | >= 2.3.0        |
+| >= 30.0.0         | >= 2.0.0        |
+| >= 29.7.0         | >= 1.6.0        |
+| >= 29.6.0         | >= 1.4.0        |
+| >= 29.5.2         | >= 1.3.0        |
+| >= 29.3.3         | >= 1.2.0        |
+| >= 29.2.0         | >= 1.1.0        |
+| >= 29.1.0         | >= 1.0.0        |
 
 ## Dependencies