[WIP]: Lightcurve Periodogram#162
Open
christinahedges wants to merge 11 commits into
Open
Conversation
mirca
reviewed
Jan 3, 2018
| self.flux = self.flux[ok] | ||
| self.flux_err = self.flux_err[ok] | ||
|
|
||
| def LombScargle(self,samples=40): |
mirca
reviewed
Jan 3, 2018
| phase : float, optional | ||
| Time reference point. | ||
| def draw(self): | ||
| raise NotImplementedError("Should we implement a LightCurveDrawer class?") |
Member
There was a problem hiding this comment.
Not sure why this got readded, you might want to rebase
mirca
reviewed
Jan 3, 2018
| sorted_args = np.argsort(fold_time) | ||
| return LightCurve(fold_time[sorted_args], self.flux[sorted_args]) | ||
| def to_csv(self): | ||
| raise NotImplementedError() |
mirca
reviewed
Jan 3, 2018
|
|
||
| def periodogram(self, minper=None, maxper=None, nterms=1): | ||
| """ | ||
| Creates a periodogram object |
Member
There was a problem hiding this comment.
not sure if that's the best purpose for a method.
maybe we want to implement something more specific?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a new class to handle automatic period searching. Currently uses astropy Lomb-Scargle, but will ideally add BLS for automatic planet searching.
Main change in lightcurve is that if no period is passed the best fitting one will automatically be found (same with phase).
WIP, working on unit tests.