added UTs for visualizer by anusghos · Pull Request #48 · Keysight/infragraph

anusghos · 2026-04-02T05:57:10Z

This PR contains Unit Tests for the visualizer and some mock data for testing.
The UTs asserts:

if the number of nodes in the graph generated for devices, fabrics and composed devices are correct.
if edges between nodes exist.
if html, css and js files are generated.
if all input types (infra object, yaml and json) are working

harsh-sikhwal · 2026-04-06T13:52:26Z

src/tests/test_visualizer/test_visualizer.py

+    assert len(cx5_edges) > 0, "cx5_100gbe should have edges"
+
+@pytest.mark.asyncio
+async def test_json_file():


Create a fabric, dump it as json and test that json. Do the same for yaml. This way we can get rid of the mock_data

fixed in commit 5b584be

harsh-sikhwal · 2026-04-06T13:53:36Z

src/tests/test_visualizer/test_visualizer.py

+    current_dir = os.path.dirname(os.path.abspath(__file__))
+    mock_data_path = os.path.join(current_dir, "mock_data")
+    json_path = os.path.join(mock_data_path, "SYS-221H-TNR.json")
+    output_dir="./viz3"


use pytest native tmp_path or some fixture that returns a tmp directory - also add them to gitignore if not already present

added pytest fixture in commit 5b584be

harsh-sikhwal · 2026-04-06T13:54:19Z

src/tests/test_visualizer/test_visualizer.py

+    switch = Switch(port_count=4)
+    clos_fat_tree = ClosFatTreeFabric(switch, server, 3, [])
+    output_dir="./viz1"
+    run_visualizer(infrastructure=clos_fat_tree,hosts="server", switches="switch",output=output_dir)


provide better spacing - I see no space here:
"switch",output=output_dir

fixed in commit 5b584be

harsh-sikhwal · 2026-04-06T13:55:28Z

src/tests/test_visualizer/test_visualizer.py

+
+
+@pytest.mark.asyncio
+async def test_closfabric_3tier_4radix():


improper naming convention - provide full names like three tier radix four
or just provide test_visualizer_closfabric

fixed in commit 5b584be

harsh-sikhwal · 2026-04-06T13:55:54Z

src/tests/test_visualizer/test_visualizer.py

@@ -0,0 +1,85 @@
+import pytest


no need to have a folder - you can have the file under src/tests/test_visualizer.py

fixed in commit 362ee3f

harsh-sikhwal · 2026-04-06T13:56:13Z

src/tests/test_visualizer/mock_data/SYS-221H-TNR.json

@@ -0,0 +1,305 @@
+{


delete this file - we do not want to keep resources

done, removed the old files

harsh-sikhwal · 2026-04-06T13:56:19Z

src/tests/test_visualizer/mock_data/dgx_a100/infra.yaml

@@ -0,0 +1,193 @@
+devices:


delete this file - we do not want to keep resources

removed in commit 362ee3f

harsh-sikhwal · 2026-04-06T13:56:43Z

src/tests/test_visualizer/test_visualizer.py

+from infragraph.visualizer.visualize import run_visualizer
+
+
+def _load_graph_data(output_dir):


not required as we are already using infra objects

keeping _load_graph_data() as it's a shared helper used by multiple tests to parse and validate the generated graph_data.js file. It extracts the JSON from the JS output so tests can assert on node/edge counts.

harsh-sikhwal · 2026-04-06T13:57:06Z

src/tests/test_visualizer/test_visualizer.py

+    data = _load_graph_data(output_dir)
+    assert len(data) > 1, "Should have infrastructure and at least one device view"
+
+


add a test for dgx device - maybe a higher variant

added tests for a compossibility graph in commit 5b584be

harsh-sikhwal · 2026-04-06T13:57:30Z

src/tests/test_visualizer/test_visualizer.py

+
+@pytest.mark.asyncio
+async def test_composed_devices():
+    """


use infragraph object rather than yaml

ajbalogh · 2026-04-09T13:03:22Z

src/tests/test_visualizer.py

+    assert os.path.exists(os.path.join(output_dir, "js", "graph_data.js")), "graph_data.js not generated"
+    assert os.path.exists(os.path.join(output_dir, "css", "style.css")), "CSS file not copied"
+
+    data = _load_graph_data(output_dir)


is there a reason why Api().set_graph() is not being used, for loading and validation?

set_graph() is already called internally in visualize.py (in run_visualizer()).

_load_graph_data is a test helper that parses the generated graph_data.js output file against which all assertions are running.

added UTs for visualizer

8d4c5f0

anusghos requested a review from harsh-sikhwal as a code owner April 2, 2026 05:57

harsh-sikhwal requested changes Apr 6, 2026

View reviewed changes

anusghos added 3 commits April 7, 2026 07:52

addressed changes

5b584be

removed files

362ee3f

fixed assert error message

1568460

harsh-sikhwal approved these changes Apr 9, 2026

View reviewed changes

ajbalogh reviewed Apr 9, 2026

View reviewed changes



		@pytest.mark.asyncio
		async def test_closfabric_3tier_4radix():

		from infragraph.visualizer.visualize import run_visualizer


		def _load_graph_data(output_dir):

		data = _load_graph_data(output_dir)
		assert len(data) > 1, "Should have infrastructure and at least one device view"

Conversation

anusghos commented Apr 2, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anusghos Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

anusghos Apr 8, 2026 •

edited

Loading