Skip to content

[🔥AUDIT🔥] Remove unused backwards compatibility feature for terraform action #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[🔥AUDIT🔥] Remove unused backwards compatibility feature for terraform action #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9720462
[rm-unused-compat] Remove unused backwards compatibility feature for …
jwbron Sep 8, 2025
af7fd28
[rm-unused-compat] add changeset
jwbron Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/empty-hounds-push.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"generate-terraform-plan": minor
---

Remove unused backwards compatibility feature
11 changes: 0 additions & 11 deletions actions/generate-terraform-plan/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,17 +89,6 @@ runs:
shell: bash
working-directory: ${{ inputs.terraform_path }}
run: |
# Handle backward compatibility with tf_vars_json
if [[ -n "$TF_VARS_JSON" && "$TF_VARS_JSON" != "{}" ]]; then
echo "Warning: tf_vars_json is deprecated. Use TF_VAR_* environment variables instead."
# Convert JSON to TF_VAR_ environment variables for backward compatibility
echo "$TF_VARS_JSON" | jq -r 'to_entries | .[] | "export TF_VAR_\(.key)=\(.value)"' | while read -r line; do
if [[ -n "$line" ]]; then
eval "$line"
fi
done
fi

# Terraform locks state during `plan` by default for safety. In our workflow,
# only the plan produced on the configured base/apply branch (`pr_creation_branch`,
# usually `main`/`master`) is intended for a subsequent `apply`, and applies always
Expand Down
Loading