Update templates to fit within 288px #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@MrMagma why are proposing this change? |
Author
|
@kevinbarabash I was asked to do this by Caroline Charrow (@carolinecharrow). |
|
@kevinbarabash - see this Asana task from me and Cam for more info: https://app.asana.com/0/27216215224639/151744303067859 |
|
@carolinecharrow - If I understand correctly, this is going to make all of our graphies in the browser (on desktop too) to be rendered significantly smaller. Is that what we want? Are there design considerations here? |
|
That's correct, with the goal of being mobile-first - Cam said he's going to talk to you about it tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the graph templates so that by default they will fit into a 288-pixel width.
Screenshots