Prime jenkins-jobs for the rename of #1s-and-0s-deploys to #eng-deploys-frontend#340
Open
lillialexis wants to merge 1 commit intomasterfrom
Open
Prime jenkins-jobs for the rename of #1s-and-0s-deploys to #eng-deploys-frontend#340lillialexis wants to merge 1 commit intomasterfrom
lillialexis wants to merge 1 commit intomasterfrom
Conversation
|
Can we switch to the channel ID instead, so that it will be valid before the name change? |
Member
Not usefully -- a lot of these changes are in dialog boxes, and we want the default value to be human-readable. I believe that old names continue to work even after a rename, so I'm not too worried about this. But I'm happy for this to be landed after the rename is done! |
csilvers
approved these changes
Jul 8, 2025
Member
csilvers
left a comment
csilvers
left a comment
There was a problem hiding this comment.
In this repo, it seems to be mostly comments and test data.
That's not true? -- it is almost all in code. Maybe copy-pasta from another repo?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
See the Slack conversation here: https://khanacademy.slack.com/archives/C06P903SXV3/p1746654728788099
This just primes the code for an eventual rename of the channel in Slack. In this repo, it seems to be mostly comments and test data.
Related PRs:
Issue: FEI-6727
Driver: lilli@khanacademy.org
Test plan: