Fix selection over on MathJax interaction #15
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We noticed that for MathJax only interaction it could cause issue
as the
trimLeft/Right
function gets into infinite loop (wow!).This might be the contribution of some of the slowness issue we see.
This is a fix for that. We also ensure that the space around the
text is displayed properly, that give some indication of selection.
I also took a look at the upstream, but did not notice any relevant fixes
that is related.
Issue: https://khanacademy.atlassian.net/browse/DI-1513
Test plan:
Run
yarn start
Selecting on the "Pure mathjax" interaction will show this issue without the fix.
Tested on: