-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storybook] Configure Aphrodite to Not Append !important to Styles #2107
Merged
mark-fitzgerald
merged 21 commits into
main
from
LEMS-2227-adjust-aphrodite-to-not-use-important
Feb 5, 2025
Merged
Changes from 6 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
e49d6d6
docs(changeset): [Storybook] Configure Aphrodite to Not Append !impor…
698506a
Add alias to vite config file to ensure that Aphrodite doesn't append…
908d55b
Remove unnecessary import statement.
9c2bed1
Update Storybook's configuration of Vite to wrap cascade layers aroun…
1acacc2
Merge branch 'main' into LEMS-2227-adjust-aphrodite-to-not-use-important
4a233c9
Prettier.
8f8b6e1
Notes regarding dynamic styling
e735556
Adjust cross-out line to be better positioned.
5da033d
Remove refactored code.
eb6816e
docs(changeset): [Storybook] Configure Aphrodite to Not Append !impor…
977a002
Merge branch 'main' into LEMS-2227-adjust-aphrodite-to-not-use-important
62396f8
Remove older changeset file.
8eaeb12
Update unit tests and snapshots.
b8e20bc
Update snapshots
8756b0f
[LEMS-2227-adjust-aphrodite-to-not-use-important] Merge branch 'main'…
mark-fitzgerald b047e3c
[LEMS-2227-adjust-aphrodite-to-not-use-important] Merge branch 'main'…
mark-fitzgerald 960e11d
[LEMS-2227-adjust-aphrodite-to-not-use-important] Merge branch 'main'…
mark-fitzgerald ba8bb5a
[LEMS-2227-adjust-aphrodite-to-not-use-important] Adding console mess…
mark-fitzgerald 387b30d
[LEMS-2227-adjust-aphrodite-to-not-use-important] Merge branch 'main'…
mark-fitzgerald ba439ee
[LEMS-2227-adjust-aphrodite-to-not-use-important] Adjust color for pr…
mark-fitzgerald 4f0f8cf
[LEMS-2227-adjust-aphrodite-to-not-use-important] Merge branch 'main'…
mark-fitzgerald File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@khanacademy/perseus-dev-ui": patch | ||
--- | ||
|
||
[Storybook] Configure Aphrodite to Not Append !important to Styles |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for documenting the exit path. Do you think it's worth creating a ticket and noting it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I vote for a ticket created and linked here so we don't forget. 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.