Add mutual assignability tests for parsed types <-> data-schema types #2402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +57 B (+0.01%) Total Size: 466 kB
ℹ️ View Unchanged
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (c48f89b) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR2402If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.js -t PR2402 |
benchristel
force-pushed
the
benc/no-readonly
branch
from
844e18c to
1aad140
Compare
…n catch more issues
…that the data format accepted by `parseAndMigratePerseusItem` stays in sync with the types in `data-schema.ts`, exported from `@khanacademy/perseus-core`.
benchristel
force-pushed
the
benc/mutual-assignability
branch
from
1f59a66 to
e710c9c
Compare
jeremywiebe
approved these changes
Apr 22, 2025
| @@ -53,7 +47,7 @@ function deprecatedSimplifyValuesToRequired( | |||
| | null | |||
| | undefined | |||
| | boolean, | |||
| ): PerseusNumericInputSimplify { | |||
| ): "enforced" | "required" | "optional" { | |||
There was a problem hiding this comment.
Did you change this because the type tests will now verify the return value matches PerseusNumericInputSimplify?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These typetests ensure that our parsers stay in sync with the data-schema types.
but don't update the parser, you will get a type error.
you will get a type error.
While adding these typetests, I found some discrepancies in our existing types, which are
fixed in this PR.
Test plan:
pnpm tsc