Proof-of-Concept: A New™️ Preview System #3018
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🗄️ Schema Change: No Changes ✅ |
Contributor
🛠️ Item Splitting: No Changes ✅ |
Contributor
|
Size Change: +1.07 kB (+0.22%) Total Size: 499 kB
ℹ️ View Unchanged
|
jeremywiebe
commented
Nov 5, 2025
| <link | ||
| rel="preload" | ||
| href="https://fonts.googleapis.com/css?family=Inconsolata" | ||
| as="style" |
Collaborator
Author
There was a problem hiding this comment.
The browser was complaining that a <link rel="preload" needs an as attribute.
jeremywiebe
commented
Nov 5, 2025
| }; | ||
|
|
||
| const storybookPreviewUrl = React.useMemo(() => { | ||
| return `${window.location.origin}/iframe.html?id=dev-support-preview--default&viewMode=story`; |
Collaborator
Author
There was a problem hiding this comment.
This is derived from the story in testing/preview.stories.tsx
jeremywiebe
commented
Nov 5, 2025
| }} | ||
| /> | ||
|
|
||
| <PreviewPanel openButtonText="Open preview (storybook only)"> |
Collaborator
Author
There was a problem hiding this comment.
If production preview is working, I don't think we need this at all.
jeremywiebe
force-pushed
the
jer/preview-like-prod
branch
2 times, most recently
from
803408d to
278a1dd
Compare
github-actions
bot
added
schema-change
…ry that acts as iframe content page
…tValue props as we only set them to mobile
…ing event.source)
…r want to change it
…my/perseus-editor
…de of the editor package
… the preview frame when its ready
jeremywiebe
force-pushed
the
jer/preview-like-prod
branch
from
278a1dd to
1266712
Compare
jeremywiebe
changed the title
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (e485e45) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3018If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3018If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3018 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Issue: --hackathon--
Test plan: