-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WB-1853] Button: Refactor theme to support semanticColor tokens #2431
Draft
jandrade
wants to merge
4
commits into
wb-semantic-color-refactor
Choose a base branch
from
wb-button-semantic
base: wb-semantic-color-refactor
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0aa3431 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jandrade
changed the title
[WB-1853]
[WB-1853] Button: Refactor theme to support semanticColor tokens
Jan 16, 2025
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-mkzzciueot.chromatic.com/ Chromatic results:
|
Size Change: +296 B (+0.31%) Total Size: 96.9 kB
ℹ️ View Unchanged
|
…This replaces the use of `color` primitive tokens in favor of semantic color tokens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Now that we have
semanticColor
tokens available, this PR is responsible forrefactoring the existing
Button
code to use these tokens instead of thecolor
primitive tokens. Also, it modifies the theme structure to followcloser the semantic color tokens structure.
Also added a
light.destructive.disabled
variant to the Dark story as we didn'tinclude a snapshot for it.
Issue: WB-1853
Test plan:
Navigate to
/?path=/docs/packages-button--docs
and verify that the buttonhasn't changed.