[hack25-darkmode] Migrate color to semantiColor in __docs__ folder #2853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c62d629 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Size Change: 0 B Total Size: 109 kB ℹ️ View Unchanged
|
Contributor
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-kqiwiiskta.chromatic.com/ Chromatic results:
|
Contributor
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Contributor
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (13e978a) and published all packages with changesets to npm. You can install the packages in ./dev/tools/deploy_wonder_blocks.js --tag="PR2853"Packages can also be installed manually by running: pnpm add @khanacademy/wonder-blocks-<package-name>@PR2853 |
marcysutton
reviewed
Nov 10, 2025
Member
marcysutton
left a comment
marcysutton
left a comment
There was a problem hiding this comment.
Thanks for updating the docs! I left one question about a disabled token on examples that aren't disabled...otherwise looks good to me!
|
|
||
| item: { | ||
| background: color.offBlack32, | ||
| background: semanticColor.core.background.disabled.strong, |
Member
There was a problem hiding this comment.
This story doesn't appear to have disabled characteristics...should it use a disabled token?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Migrated all the
colorinstances in the__docs__folder tosemantiColor.This was the result of the WB codemod created for this task.
Issue: "none"
Test plan:
Verify that the changes make sense and that nothing breaks from this. There
might be slight changes in the stories, but component styles shouldn't have
changed.