-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[fei5402.1.node20workflows] Change workflows to node 20 (#990)
## Summary: This updates our Wonder Blocks workflows to use Node 20. In order to verify things, I learned some additional steps for macOS. 1. Switch to node 20 (I use NVM, so `nvm use 20`) 1. Run `yarn` or `yarn install` 1. If you get an error about `node-gyp`. You either need to install XCode command line tools (You can do this by running `xcode-select --install` and following the prompts), or switch to use those tools from your version of XCode (XCode 14.3.1 appears to cause a lot of errors) - you can do this by running `sudo xcode-select -s /Library/Developer/CommandLineTools`. 1. Re-run `yarn` or `yarn install` after this and all should be well. Issue: FEI-5402 ## Test plan: See above steps to get things installed properly for macOS. I then ran: - `yarn test` - `yarn lint` - `yarn typecheck` - `yarn build` Author: somewhatabstract Reviewers: jeresig Required Reviewers: Approved By: jeresig Checks: ✅ codecov/project, ✅ Test (macos-latest, 20.x), ✅ CodeQL, ✅ Lint, typecheck, and coverage check (ubuntu-latest, 20.x), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ✅ gerald, ⏭️ dependabot, ✅ Analyze (javascript) Pull Request URL: #990
- Loading branch information
1 parent
7d4b0d9
commit d6296d4
Showing
7 changed files
with
250 additions
and
172 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
--- | ||
--- |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.