-
Notifications
You must be signed in to change notification settings - Fork 1
Rename file to match generate-package-json.ts #1232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 3b97ade The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1232 +/- ##
=======================================
Coverage 82.79% 82.79%
=======================================
Files 63 63
Lines 843 843
Branches 209 209
=======================================
Hits 698 698
Misses 145 145
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
Size Change: 0 B Total Size: 4.22 kB ℹ️ View Unchanged
|
somewhatabstract
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve of this change. Thanks!
Summary:
I'm creating this PR so I have a code change that can trigger a new release.
Backstory: I thought I had published this package once already, but I hadn't. When I cut the v0.0.2 release it failed because the package does not exist on npmjs.com yet and can't be published without Trusted Publishing being enabled (the exact problem this tool is meant to help with).
Since then, I've manually published a placeholder package and enabled Trusted Publishing on npmjs (https://www.npmjs.com/package/@khanacademy/wonder-stuff-tool-publish-new-pkg/access).
When this PR is landed we can cut the release and it should publish successfully.
Issue: LEMS-3681
Test plan: