Conversation
Khang-NT
reviewed
Apr 1, 2018
|
|
||
| (activity as? OnSubmittedListener)?.onSubmitted(this) | ||
| ?: Timber.w("Host activity does not implement OnSubmittedListener") | ||
| getTrimFragment().validateAndGetBeginEndPostition { beginEndPosition -> |
Owner
There was a problem hiding this comment.
Misleading name begin - end instead of start - duration
Owner
There was a problem hiding this comment.
Can be data class TrimPosition(val startPos: Float, val duration: Float, ...)
Khang-NT
requested changes
Apr 1, 2018
| } | ||
|
|
||
| btnMarkEnd.setOnClickListener { | ||
| edEndPos.setText("9999999") |
Owner
There was a problem hiding this comment.
Magic number
It's hard to understand what is this number, let name it:
const val MAX_DURATION = "99999999"
ghost
approved these changes
May 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#78