Fix parallel build of loadtest apps#1225
Open
MarkCallow wants to merge 15 commits into
Open
Conversation
Works except for KTX files that appear in multiple load test targets. Safety check-in.
Successfully configures and generates the projects. Another safety check-in.
Perform small cleanup.
* Update copyright dates. * ICON_SOURCE_PATH to ICON_SOURCE for consistency with other uses of SOURCE.
The .spv files were being included.
CMake does not offer a 100% working way to for a custom command to create just a directory.
Add make_directory command to all custom resource commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reinstate previously disabled parallel builds.
The issue was use of custom commands (add_custom_command) to copy resource files to a directory near the just-built executable, which is done for ease of testing and debugging. These commands were used by both the vkloadtests and gl3loadtests targets which meant races were possible.
The changes the copying to be done via custom targets which have a defined ordering and will only be built once. These target invoke very similar custom commands to do the actual work.
Only Windows and Linux builds are affected. The resource copying is not needed on macOS because the apps are built as bundles including all the resource files.
Other included changes are: