Add tests for cl_ext_immutable_memory_objects #2286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Rizkalla <[email protected]>
This change does the following: 1. Create `negative_enqueue_map_image` with tests for mapping images created with `CL_MEM_IMMUTABLE_EXT` 2. Update `enqueue_map_*` with more variants of `cl_mem_flags` Signed-off-by: Michael Rizkalla <[email protected]>
This change updates `cl_khr_command_buffer` test binary to include behaviour with `CL_MEM_IMMUTABLE_EXT` memory flag. Added the following tests: 1. negative_copy_to_immutable_buffer 2. negative_copy_image_to_immutable_buffer 3. negative_copy_to_immutable_buffer_rect 4. negative_copy_to_immutable_image 5. negative_copy_buffer_to_immutable_image 6. negative_fill_immutable_image 7. negative_fill_immutable_buffer Signed-off-by: Michael Rizkalla <[email protected]>
This change adds `negative_set_immutable_memory_to_writeable_kernel_arg` to verify setting memory arguments marked with `CL_MEM_IMMUTABLE_EXT`. Signed-off-by: Michael Rizkalla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change provides partial test coverage for KhronosGroup/OpenCL-Docs#1280
Adding CTS tests for:
The bulk of the tests is to make sure that the CL driver does not allow writing to a memory object that is created with
CL_MEM_IMMUTABLE_EXTflag when used with the above APIs.