Skip to content

Conversation

@GermanAizek
Copy link

Copy link
Contributor

@cdavis5e cdavis5e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Historically, CMake build systems that use ccache(1) automatically have caused problems for me, e.g. when installing ports from source in MacPorts. Then again, I suppose it's easy enough to work around that with -DCCACHE_FOUND=NO.


find_program(CCACHE_FOUND ccache)
if (CCACHE_FOUND)
set_property(GLOBAL PROPERTY RULE_LAUNCH_COMPILE ccache)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the find_program() above, the variable CCACHE_FOUND will contain the full pathname of the ccache program. You should probably use it, instead of assuming that ccache will be in the user's PATH.

@HansKristian-Work
Copy link
Contributor

HansKristian-Work commented Jan 18, 2024

Is there really a point adding this? This isn't a massive project where ccache really helps. At the very least, it should be opt-in, not enabled by default.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants