Fix using buffer reference blocks as struct members in glsl#2482
Merged
Conversation
Buffer reference blocks are always emitted after structs, even when forward declared. This causes invalid GLSL to be generated if a buffer reference block is used as a struct member. This patch fixes the problem by emitting buffer reference block forward declarations before emitting structs. Change-Id: I27dd9a8855f3514f48689a9203f9562f387b55af Signed-off-by: Patrik Wallin Hybelius <patrik.wallinhybelius@arm.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buffer reference blocks are always emitted after structs, even when forward declared. This causes invalid GLSL to be generated if a buffer reference block is used as a struct member.
This patch fixes the problem by emitting buffer reference block forward declarations before emitting structs.