Geometry shader support for HLSL#2483
Merged
HansKristian-Work merged 20 commits intoMay 27, 2025
Merged
Conversation
|
|
HansKristian-Work
requested changes
May 22, 2025
…ncluding testing non-emitters and pass-through emitters.
… it, emit geometry.
…end the geoemtry stream to the end of the arg list.
…he geometry stream as an argument to functions that emit geometry.
ashleyharris-maptek-com-au
force-pushed
the
GeometryShadersHlsl
branch
from
f15defc to
4df1db5
Compare
ashleyharris-maptek-com-au
force-pushed
the
GeometryShadersHlsl
branch
from
4df1db5 to
16503b2
Compare
…ed after clangformat over-revert)
HansKristian-Work
requested changes
May 23, 2025
HansKristian-Work
left a comment
HansKristian-Work
left a comment
Contributor
There was a problem hiding this comment.
With the reflowing and the analysis fixed, I guess this will be acceptable for merge.
…ywhere, it is strongly typed anyways.
…s not the way to do it.
… HLSL so we can just call it geometry_stream.
ashleyharris-maptek-com-au
force-pushed
the
GeometryShadersHlsl
branch
from
7a386f1 to
c674dc4
Compare
… revert to un-clang-formatted the now untouched code.
…y unpacking code, and added the hlsl/opt reference shader too.
pablode
pushed a commit
to pablode/SPIRV-Cross
that referenced
this pull request
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Geometry shaders can now be outputted to HLSL.
This allows apps that ship with precompiled SPIRV shaders to target Direct3D environments even if they use geometry shaders.