MSL: Fix generation of the WorkgroupSize built-in.#2491
Merged
HansKristian-Work merged 1 commit intoJun 11, 2025
Conversation
Use any existing `gl_WorkGroupSize` when adding an implicit `WorkgroupSize`. Make a constant using the `LocalSize` or `LocalSizeId` when those execution modes are set. Only when none is present do we add the `WorkgroupSize` as an input. Of course, since the `GLCompute` model requires one of the three of constant `WorkgroupSize`, `LocalSize`, or `LocalSizeId` to be present, this shouldn't happen in practice, but I thought I'd handle it properly anyway.
HansKristian-Work
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use any existing
gl_WorkGroupSizewhen adding an implicitWorkgroupSize. Make a constant using theLocalSizeorLocalSizeIdwhen those execution modes are set. Only when none is present do we add theWorkgroupSizeas an input. Of course, since theGLComputemodel requires one of the three of constantWorkgroupSize,LocalSize, orLocalSizeIdto be present, this shouldn't happen in practice, but I thought I'd handle it properly anyway.