GLSL: support SPIR-V library modules#2628
Merged
Merged
Conversation
HansKristian-Work
force-pushed
the
glsl-library-mode
branch
from
5834720 to
0a2258e
Compare
Contributor
|
Rebased it since there were conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends library-mode SPIR-V support to the GLSL backend, mirroring the HLSL emit and test changes from earlier PRs in this stack.
I think the main question is how to implement
emit_header()I'm currently emitting a comment and skipping the#versionand#extensiondirectives, but as discussed in #2622 this may not be the best choice. I'm open to other suggestions.I've also added two additional tests mirroring the HLSL tests. The main difference is the way these tests are validated by creating a minimal stub that includes the generated code.
Stacked on #2627. Addresses issue #2622.