Library modules export all global variables regardless of SPIR-V version.#2632
Merged
HansKristian-Work merged 19 commits intoMay 12, 2026
Merged
Conversation
This removes the need for a special case for default_entry_point and correctly handles exports that call other exports.
Contributor
|
Shouldn't this be rebased? Having 10+ commits like this is just weird. |
Contributor
|
Anyway, it's trivial, so can take squash approach. |
HansKristian-Work
approved these changes
May 12, 2026
Contributor
Author
|
The commit sequence is the result of stacked PRs, but I think for the most part can be ignored, merging the PR squashes the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per discussion in #2622, in SPIR-V 1.4 global variables must be declared by the
OpEntryPoint's interface list. However, library modules do not have entry points, so default to the previous behavior and export all globals.