Fix OpGroupAsyncCopy used with SPV_KHR_untyped_pointers#2819
Draft
vmaksimo wants to merge 1 commit intoKhronosGroup:mainfrom
Draft
Fix OpGroupAsyncCopy used with SPV_KHR_untyped_pointers#2819vmaksimo wants to merge 1 commit intoKhronosGroup:mainfrom
vmaksimo wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
MrSidims
reviewed
Oct 31, 2024
| if (BM->isAllowedToUseExtension(ExtensionID::SPV_KHR_untyped_pointers) && | ||
| !(ET->isTypeArray() || ET->isTypeVector() || ET->isTypeStruct() || | ||
| ET->isTypeImage() || ET->isTypeSampler() || ET->isTypePipe())) { | ||
| ET->isTypeImage() || ET->isTypeSampler() || ET->isTypePipe() || |
MrSidims
requested changes
Oct 31, 2024
Contributor
MrSidims
left a comment
MrSidims
left a comment
There was a problem hiding this comment.
After offline discussion: we have to re-evaluate this patch. Reasons:
- OpGroupAsyncCopy doesn't work well with opaque pointers in general;
- regardless how OpGroupAsyncCopy would work - insertion of a bitcast is incorrect in this case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.