Skip to content

Implement SPV_INTEL_ternary_bitwise_function #3104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 9, 2025
Merged

Implement SPV_INTEL_ternary_bitwise_function #3104

merged 4 commits into from
Apr 9, 2025

Conversation

steffenlarsen
Copy link
Contributor

This commit implements support for bi-directional translation of the BitwiseFunctionINTEL operation added in
https://github.khronos.org/SPIRV-Registry/extensions/INTEL/SPV_INTEL_ternary_bitwise_function.html together with the corresponding capability.

@steffenlarsen
Implement SPV_INTEL_ternary_bitwise_function
1505380 
This commit implements support for bi-directional translation of the
`BitwiseFunctionINTEL` operation added in
https://github.khronos.org/SPIRV-Registry/extensions/INTEL/SPV_INTEL_ternary_bitwise_function.html
together with the corresponding capability.

Signed-off-by: Larsen, Steffen <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Apr 2, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@steffenlarsen steffenlarsen mentioned this pull request Apr 2, 2025
Draft
MrSidims
MrSidims reviewed Apr 3, 2025
View reviewed changes
Copy link
Contributor

@MrSidims MrSidims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you have plans to implement it in SPIR-V backend?

lib/SPIRV/libSPIRV/spirv_internal.hpp Outdated
@@ -118,7 +119,8 @@ enum InternalCapability {
ICapabilityJointMatrixPackedInt4ComponentTypeINTEL = 6439,
ICapabilityCacheControlsINTEL = 6441,
ICapabilitySubgroupRequirementsINTEL = 6445,
ICapabilityBindlessImagesINTEL = 6528
ICapabilityBindlessImagesINTEL = 6528,
ICapabilityTernaryBitwiseFunctionINTEL = 6241
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the extension up-streamed to SPIR-V Headers? If so, lets use definitions from there.

@steffenlarsen
Copy link
Contributor Author

Thanks! Do you have plans to implement it in SPIR-V backend?

Was the extension up-streamed to SPIR-V Headers?

I admit, I've fallen a little behind on the SPIR-V translator and constituent projects. Where do these live? 😄

@MrSidims
Copy link
Contributor

MrSidims commented Apr 4, 2025 •
edited
Loading

@steffenlarsen here you are: https://github.com/llvm/llvm-project/tree/main/llvm/lib/Target/SPIRV for the backend and https://github.com/KhronosGroup/SPIRV-Headers for the headers. Unified spirv headers is taken from the latter by default by the translator, so may be what you need to do, if definitions for the extension present there, is to update names and remove internal::.

@steffenlarsen
Copy link
Contributor Author

steffenlarsen commented Apr 8, 2025 •
edited
Loading

Looks like the header changes have already been made in KhronosGroup/SPIRV-Headers#504 and my local testing just didn't reflect that. Should be addressed now!

Edit: Looks like the SPIR-V headers tag need an update. Can I do that as part of this patch or does it have to be separate?

@MrSidims
Copy link
Contributor

MrSidims commented Apr 8, 2025

Looks like the header changes have already been made in KhronosGroup/SPIRV-Headers#504 and my local testing just didn't reflect that. Should be addressed now!

Edit: Looks like the SPIR-V headers tag need an update. Can I do that as part of this patch or does it have to be separate?

You can to it in this PR.

@steffenlarsen
Bump tag
c998e00 
Signed-off-by: Larsen, Steffen <[email protected]>
MrSidims
MrSidims approved these changes Apr 8, 2025
View reviewed changes
@steffenlarsen
Copy link
Contributor Author

SPIR-V backend implementation patch: llvm/llvm-project#134866

@MrSidims MrSidims merged commit f646fce into KhronosGroup:main Apr 9, 2025
6 of 9 checks passed
@MrSidims
Copy link
Contributor

/backport llvm_release_200

@github-actions GitHub Actions
Copy link

Attempting to create backport to llvm_release_200...

github-actions bot pushed a commit that referenced this pull request May 19, 2025
@steffenlarsen @MrSidims
Implement SPV_INTEL_ternary_bitwise_function (#3104)
e5d0432 
This commit implements support for bi-directional translation of the
`BitwiseFunctionINTEL` operation added in

https://github.khronos.org/SPIRV-Registry/extensions/INTEL/SPV_INTEL_ternary_bitwise_function.html
together with the corresponding capability.

Signed-off-by: Larsen, Steffen <[email protected]>
@github-actions GitHub Actions
Copy link

Success. Backport PR created: #3182

@github-actions github-actions bot mentioned this pull request May 19, 2025
Open
@MrSidims
Copy link
Contributor

/backport llvm_release_190

@MrSidims
Copy link
Contributor

/backport llvm_release_180

@github-actions GitHub Actions
Copy link

Attempting to create backport to llvm_release_190...

@MrSidims
Copy link
Contributor

/backport llvm_release_170

@github-actions GitHub Actions
Copy link

Backport to llvm_release_190 failed due to conflicts on commit f646fce01daaaaf3c4776b8253490c50d0da4bb1. Please backport manually.

@github-actions GitHub Actions
Copy link

Attempting to create backport to llvm_release_180...

@github-actions GitHub Actions
Copy link

Backport to llvm_release_180 failed due to conflicts on commit f646fce01daaaaf3c4776b8253490c50d0da4bb1. Please backport manually.

@github-actions GitHub Actions
Copy link

Attempting to create backport to llvm_release_170...

@github-actions GitHub Actions
Copy link

Backport to llvm_release_170 failed due to conflicts on commit f646fce01daaaaf3c4776b8253490c50d0da4bb1. Please backport manually.

MrSidims pushed a commit to MrSidims/SPIRV-LLVM-Translator that referenced this pull request May 27, 2025
@steffenlarsen @MrSidims
[Backport to 19] Implement SPV_INTEL_ternary_bitwise_function (Khrono…
b96042c 
…sGroup#3104)

This commit implements support for bi-directional translation of the
`BitwiseFunctionINTEL` operation added in

https://github.khronos.org/SPIRV-Registry/extensions/INTEL/SPV_INTEL_ternary_bitwise_function.html
together with the corresponding capability.

Signed-off-by: Larsen, Steffen <[email protected]>
vmaksimo pushed a commit that referenced this pull request May 28, 2025
@steffenlarsen @vmaksimo
[Backport to 19] Implement SPV_INTEL_ternary_bitwise_function (#3104)
847a386 
This commit implements support for bi-directional translation of the
`BitwiseFunctionINTEL` operation added in

https://github.khronos.org/SPIRV-Registry/extensions/INTEL/SPV_INTEL_ternary_bitwise_function.html
together with the corresponding capability.

Signed-off-by: Larsen, Steffen <[email protected]>
vmaksimo pushed a commit to vmaksimo/SPIRV-LLVM-Translator that referenced this pull request Jun 4, 2025
@steffenlarsen @vmaksimo
[Backport to 18] Implement SPV_INTEL_ternary_bitwise_function (Khrono…
8d953d6 
…sGroup#3104)

This commit implements support for bi-directional translation of the
`BitwiseFunctionINTEL` operation added in

https://github.khronos.org/SPIRV-Registry/extensions/INTEL/SPV_INTEL_ternary_bitwise_function.html
together with the corresponding capability.

Signed-off-by: Larsen, Steffen <[email protected]>
vmaksimo pushed a commit to vmaksimo/SPIRV-LLVM-Translator that referenced this pull request Jun 4, 2025
@steffenlarsen @vmaksimo
[Backport to 18] Implement SPV_INTEL_ternary_bitwise_function (Khrono…
b351600 
…sGroup#3104)

This commit implements support for bi-directional translation of the
`BitwiseFunctionINTEL` operation added in

https://github.khronos.org/SPIRV-Registry/extensions/INTEL/SPV_INTEL_ternary_bitwise_function.html
together with the corresponding capability.

Signed-off-by: Larsen, Steffen <[email protected]>
vmaksimo pushed a commit to vmaksimo/SPIRV-LLVM-Translator that referenced this pull request Jun 4, 2025
@steffenlarsen @vmaksimo
[Backport to 17] Implement SPV_INTEL_ternary_bitwise_function (Khrono…
ef9a29e 
…sGroup#3104)

This commit implements support for bi-directional translation of the
`BitwiseFunctionINTEL` operation added in

https://github.khronos.org/SPIRV-Registry/extensions/INTEL/SPV_INTEL_ternary_bitwise_function.html
together with the corresponding capability.

Signed-off-by: Larsen, Steffen <[email protected]>
vmaksimo pushed a commit to vmaksimo/SPIRV-LLVM-Translator that referenced this pull request Jun 4, 2025
@steffenlarsen @vmaksimo
[Backport to 16] Implement SPV_INTEL_ternary_bitwise_function (Khrono…
c3ecfd3 
…sGroup#3104)

This commit implements support for bi-directional translation of the
`BitwiseFunctionINTEL` operation added in

https://github.khronos.org/SPIRV-Registry/extensions/INTEL/SPV_INTEL_ternary_bitwise_function.html
together with the corresponding capability.

Signed-off-by: Larsen, Steffen <[email protected]>
vmaksimo pushed a commit to vmaksimo/SPIRV-LLVM-Translator that referenced this pull request Jun 5, 2025
@steffenlarsen @vmaksimo
[Backport to 15] Implement SPV_INTEL_ternary_bitwise_function (Khrono…
4c0493e 
…sGroup#3104)

This commit implements support for bi-directional translation of the
`BitwiseFunctionINTEL` operation added in

https://github.khronos.org/SPIRV-Registry/extensions/INTEL/SPV_INTEL_ternary_bitwise_function.html
together with the corresponding capability.

Signed-off-by: Larsen, Steffen <[email protected]>
vmaksimo pushed a commit to vmaksimo/SPIRV-LLVM-Translator that referenced this pull request Jun 5, 2025
@steffenlarsen @vmaksimo
[Backport to 15] Implement SPV_INTEL_ternary_bitwise_function (Khrono…
fa860b6 
…sGroup#3104)

This commit implements support for bi-directional translation of the
`BitwiseFunctionINTEL` operation added in

https://github.khronos.org/SPIRV-Registry/extensions/INTEL/SPV_INTEL_ternary_bitwise_function.html
together with the corresponding capability.

Signed-off-by: Larsen, Steffen <[email protected]>
vmaksimo pushed a commit that referenced this pull request Jun 6, 2025
@steffenlarsen @vmaksimo
[Backport to 18] Implement SPV_INTEL_ternary_bitwise_function (#3104)
810df4b 
This commit implements support for bi-directional translation of the
`BitwiseFunctionINTEL` operation added in

https://github.khronos.org/SPIRV-Registry/extensions/INTEL/SPV_INTEL_ternary_bitwise_function.html
together with the corresponding capability.

Signed-off-by: Larsen, Steffen <[email protected]>
vmaksimo pushed a commit that referenced this pull request Jun 6, 2025
@steffenlarsen @vmaksimo
[Backport to 17] Implement SPV_INTEL_ternary_bitwise_function (#3104)
7a80643 
This commit implements support for bi-directional translation of the
`BitwiseFunctionINTEL` operation added in

https://github.khronos.org/SPIRV-Registry/extensions/INTEL/SPV_INTEL_ternary_bitwise_function.html
together with the corresponding capability.

Signed-off-by: Larsen, Steffen <[email protected]>
vmaksimo pushed a commit that referenced this pull request Jun 6, 2025
@steffenlarsen @vmaksimo
[Backport to 16] Implement SPV_INTEL_ternary_bitwise_function (#3104)
2f33bdb 
This commit implements support for bi-directional translation of the
`BitwiseFunctionINTEL` operation added in

https://github.khronos.org/SPIRV-Registry/extensions/INTEL/SPV_INTEL_ternary_bitwise_function.html
together with the corresponding capability.

Signed-off-by: Larsen, Steffen <[email protected]>
vmaksimo pushed a commit that referenced this pull request Jun 6, 2025
@steffenlarsen @vmaksimo
[Backport to 15] Implement SPV_INTEL_ternary_bitwise_function (#3104)
5470cf7 
This commit implements support for bi-directional translation of the
`BitwiseFunctionINTEL` operation added in

https://github.khronos.org/SPIRV-Registry/extensions/INTEL/SPV_INTEL_ternary_bitwise_function.html
together with the corresponding capability.

Signed-off-by: Larsen, Steffen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrSidims MrSidims MrSidims approved these changes

@VyacheslavLevytskyy VyacheslavLevytskyy VyacheslavLevytskyy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@steffenlarsen @CLAassistant @MrSidims @VyacheslavLevytskyy