Skip to content

SPIRV-LLVM-Translator: fix handling of built-in SPIRV targer #3166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lumag
Copy link

@lumag lumag commented May 13, 2025

If the SPIRV-LLVM-Translator is being built together with the LLVM, set the defines declaring whether SPIRV target is also included into the LLVM library or not. Otherwise llvm-spirv execution fails because spirv-ext option is registered twice.

If the SPIRV-LLVM-Translator is being built together with the LLVM, set
the defines declaring whether SPIRV target is also included into the
LLVM library or not. Otherwise llvm-spirv execution fails because
spirv-ext option is registered twice.

Signed-off-by: Dmitry Baryshkov <[email protected]>
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@lumag
Copy link
Author

lumag commented May 13, 2025

According to my information, this contribution should be covered by the Corporate OS CLA between Qualcomm and Khronos and as such should not require any extra CLA. Could you please check it?

@MrSidims
Copy link
Contributor

According to my information, this contribution should be covered by the Corporate OS CLA between Qualcomm and Khronos and as such should not require any extra CLA. Could you please check it?

@KhronosWebservices could you please comment on that?

@KhronosWebservices
Copy link
Member

I do not see @lumag in our Corporate CLA system. Can you please email me [email protected]. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants