Skip to content

Remove SPV_INTEL_fast_composite extension #3183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion include/LLVMSPIRVExtensions.inc
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ EXT(SPV_INTEL_arbitrary_precision_integers)
EXT(SPV_INTEL_optimization_hints)
EXT(SPV_INTEL_float_controls2)
EXT(SPV_INTEL_vector_compute)
EXT(SPV_INTEL_fast_composite)
EXT(SPV_INTEL_usm_storage_classes)
EXT(SPV_INTEL_fpga_buffer_location)
EXT(SPV_INTEL_arbitrary_precision_fixed_point)
Expand Down
6 changes: 0 additions & 6 deletions lib/SPIRV/PreprocessMetadata.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -359,12 +359,6 @@ void PreprocessMetadataBase::preprocessVectorComputeMetadata(Module *M,
.add(SLMSize)
.done();
}
if (Attrs.hasFnAttr(kVCMetadata::VCFCEntry)) {
EM.addOp()
.add(&F)
.add(spv::internal::ExecutionModeFastCompositeKernelINTEL)
.done();
}

if (Attrs.hasFnAttr(kVCMetadata::VCNamedBarrierCount)) {
SPIRVWord NBarrierCnt = 0;
Expand Down
6 changes: 0 additions & 6 deletions lib/SPIRV/SPIRVReader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4642,12 +4642,6 @@ bool SPIRVToLLVM::transMetadata() {
if (BM->getDesiredBIsRepresentation() == BIsRepresentation::SPIRVFriendlyIR)
transFunctionDecorationsToMetadata(BF, F);

if (BF->hasDecorate(internal::DecorationCallableFunctionINTEL))
F->addFnAttr(kVCMetadata::VCCallable);
if (isKernel(BF) &&
BF->getExecutionMode(internal::ExecutionModeFastCompositeKernelINTEL))
F->addFnAttr(kVCMetadata::VCFCEntry);

if (F->getCallingConv() != CallingConv::SPIR_KERNEL)
continue;

Expand Down
10 changes: 0 additions & 10 deletions lib/SPIRV/SPIRVWriter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1018,11 +1018,6 @@ SPIRVFunction *LLVMToSPIRVBase::transFunctionDecl(Function *F) {
BF->addDecorate(DecorationReferencedIndirectlyINTEL);
}

if (Attrs.hasFnAttr(kVCMetadata::VCCallable) &&
BM->isAllowedToUseExtension(ExtensionID::SPV_INTEL_fast_composite)) {
BF->addDecorate(internal::DecorationCallableFunctionINTEL);
}

if (BM->isAllowedToUseExtension(ExtensionID::SPV_INTEL_vector_compute))
transVectorComputeMetadata(F);

Expand Down Expand Up @@ -6280,11 +6275,6 @@ bool LLVMToSPIRVBase::transExecutionMode() {
break;
AddSingleArgExecutionMode(static_cast<ExecutionMode>(EMode));
} break;
case spv::internal::ExecutionModeFastCompositeKernelINTEL: {
if (BM->isAllowedToUseExtension(ExtensionID::SPV_INTEL_fast_composite))
BF->addExecutionMode(BM->add(new SPIRVExecutionMode(
OpExecutionMode, BF, static_cast<ExecutionMode>(EMode))));
} break;
case spv::internal::ExecutionModeNamedSubgroupSizeINTEL: {
if (!BM->isAllowedToUseExtension(
ExtensionID::SPV_INTEL_subgroup_requirements))
Expand Down
2 changes: 0 additions & 2 deletions lib/SPIRV/libSPIRV/SPIRVDecorate.h
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,6 @@ class SPIRVDecorate : public SPIRVDecorateGeneric {
return ExtensionID::SPV_INTEL_fpga_cluster_attributes;
case DecorationFuseLoopsInFunctionINTEL:
return ExtensionID::SPV_INTEL_loop_fuse;
case internal::DecorationCallableFunctionINTEL:
return ExtensionID::SPV_INTEL_fast_composite;
case DecorationMathOpDSPModeINTEL:
return ExtensionID::SPV_INTEL_fpga_dsp_control;
case DecorationInitiationIntervalINTEL:
Expand Down
2 changes: 0 additions & 2 deletions lib/SPIRV/libSPIRV/SPIRVEntry.h
Original file line number Diff line number Diff line change
Expand Up @@ -909,8 +909,6 @@ class SPIRVCapability : public SPIRVEntryNoId<OpCapability> {
case CapabilityVectorComputeINTEL:
case CapabilityVectorAnyINTEL:
return ExtensionID::SPV_INTEL_vector_compute;
case internal::CapabilityFastCompositeINTEL:
return ExtensionID::SPV_INTEL_fast_composite;
case internal::CapabilitySubgroupRequirementsINTEL:
return ExtensionID::SPV_INTEL_subgroup_requirements;
case CapabilityFPFastMathModeINTEL:
Expand Down
4 changes: 0 additions & 4 deletions lib/SPIRV/libSPIRV/SPIRVEnum.h
Original file line number Diff line number Diff line change
Expand Up @@ -290,8 +290,6 @@ template <> inline void SPIRVMap<SPIRVExecutionModeKind, SPIRVCapVec>::init() {
{CapabilityFloatingPointModeINTEL});
ADD_VEC_INIT(ExecutionModeSharedLocalMemorySizeINTEL,
{CapabilityVectorComputeINTEL});
ADD_VEC_INIT(internal::ExecutionModeFastCompositeKernelINTEL,
{internal::CapabilityFastCompositeINTEL});
ADD_VEC_INIT(ExecutionModeRegisterMapInterfaceINTEL,
{CapabilityFPGAKernelAttributesv2INTEL});
ADD_VEC_INIT(ExecutionModeStreamingInterfaceINTEL,
Expand Down Expand Up @@ -473,8 +471,6 @@ template <> inline void SPIRVMap<Decoration, SPIRVCapVec>::init() {
ADD_VEC_INIT(DecorationAliasScopeINTEL,
{CapabilityMemoryAccessAliasingINTEL});
ADD_VEC_INIT(DecorationNoAliasINTEL, {CapabilityMemoryAccessAliasingINTEL});
ADD_VEC_INIT(internal::DecorationCallableFunctionINTEL,
{internal::CapabilityFastCompositeINTEL});
ADD_VEC_INIT(DecorationMediaBlockIOINTEL, {CapabilityVectorComputeINTEL});
ADD_VEC_INIT(DecorationStallEnableINTEL,
{CapabilityFPGAClusterAttributesINTEL});
Expand Down
2 changes: 0 additions & 2 deletions lib/SPIRV/libSPIRV/SPIRVNameMapEnum.h
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,6 @@ template <> inline void SPIRVMap<Decoration, std::string>::init() {
add(DecorationCacheControlStoreINTEL, "CacheControlStoreINTEL");

// From spirv_internal.hpp
add(internal::DecorationCallableFunctionINTEL, "CallableFunctionINTEL");
add(internal::DecorationRuntimeAlignedINTEL, "RuntimeAlignedINTEL");
add(internal::DecorationHostAccessINTEL, "HostAccessINTEL");
add(internal::DecorationInitModeINTEL, "InitModeINTEL");
Expand Down Expand Up @@ -652,7 +651,6 @@ template <> inline void SPIRVMap<Capability, std::string>::init() {
"SubgroupMatrixMultiplyAccumulateINTEL");
add(CapabilityTernaryBitwiseFunctionINTEL, "TernaryBitwiseFunctionINTEL");
// From spirv_internal.hpp
add(internal::CapabilityFastCompositeINTEL, "FastCompositeINTEL");
add(internal::CapabilityTokenTypeINTEL, "TokenTypeINTEL");
add(internal::CapabilityJointMatrixINTEL, "JointMatrixINTEL");
add(internal::CapabilityHWThreadQueryINTEL, "HWThreadQueryINTEL");
Expand Down
9 changes: 0 additions & 9 deletions lib/SPIRV/libSPIRV/spirv_internal.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ enum InternalDecoration {
};

enum InternalCapability {
ICapFastCompositeINTEL = 6093,
ICapTokenTypeINTEL = 6112,
ICapabilityJointMatrixINTEL = 6118,
ICapabilityHWThreadQueryINTEL = 6134,
Expand All @@ -122,7 +121,6 @@ enum InternalCapability {
};

enum InternalExecutionMode {
IExecModeFastCompositeKernelINTEL = 6088,
IExecModeNamedSubgroupSizeINTEL = 6446,
};

Expand Down Expand Up @@ -253,8 +251,6 @@ constexpr SourceLanguage SourceLanguageCPP20 =
constexpr Op OpForward = static_cast<Op>(IOpForward);
constexpr Op OpTypeTokenINTEL = static_cast<Op>(IOpTypeTokenINTEL);

constexpr Decoration DecorationCallableFunctionINTEL =
static_cast<Decoration>(IDecCallableFunctionINTEL);
constexpr Decoration DecorationRuntimeAlignedINTEL =
static_cast<Decoration>(IDecRuntimeAlignedINTEL);
constexpr Decoration DecorationHostAccessINTEL =
Expand All @@ -266,16 +262,11 @@ constexpr Decoration DecorationImplementInCSRINTEL =
constexpr Decoration DecorationArgumentAttributeINTEL =
static_cast<Decoration>(IDecArgumentAttributeINTEL);

constexpr Capability CapabilityFastCompositeINTEL =
static_cast<Capability>(ICapFastCompositeINTEL);
constexpr Capability CapabilityTokenTypeINTEL =
static_cast<Capability>(ICapTokenTypeINTEL);
constexpr Capability CapabilityGlobalVariableDecorationsINTEL =
static_cast<Capability>(ICapGlobalVariableDecorationsINTEL);

constexpr ExecutionMode ExecutionModeFastCompositeKernelINTEL =
static_cast<ExecutionMode>(IExecModeFastCompositeKernelINTEL);

constexpr ExecutionMode ExecutionModeNamedSubgroupSizeINTEL =
static_cast<ExecutionMode>(IExecModeNamedSubgroupSizeINTEL);

Expand Down

This file was deleted.

This file was deleted.