[opt] Fix constant folding of OpSelect with a scalar condition - #6843
Open
cmarcelo wants to merge 1 commit into
Open
[opt] Fix constant folding of OpSelect with a scalar condition#6843cmarcelo wants to merge 1 commit into
cmarcelo wants to merge 1 commit into
Conversation
|
|
Since SPIR-V 1.4, a scalar OpSelect condition selects between whole objects, including vectors and composites. Spec constant folding evaluated it per component, asserting or producing invalid values. Handle Select with a folding rule that implements both forms.
cmarcelo
force-pushed
the
fold-select-scalar-condition
branch
from
August 15, 2026 06:00
11141cb to
5dd05ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since SPIR-V 1.4, a scalar OpSelect condition selects between whole objects, including vectors and composites. Spec constant folding evaluated it per component, asserting or producing invalid values. Handle Select with a folding rule that implements both forms.