Update acpp bypasses #1137
Update acpp bypasses #1137
Conversation
|
|
tests/accessor_generic/generic_accessor_common_buffer_tag_constructors.cpp.in
Outdated
Show resolved
Hide resolved
tests/accessor_generic/generic_accessor_common_buffer_constructors.cpp.in
Outdated
Show resolved
Hide resolved
I hope https://github.com/KhronosGroup/SYCL-CTS/blob/main/docs/README.adoc answers all your questions. Let us know if it's not the case. |
|
I'm reading the document here and it is quite useful thanks. I have a question - it doesn't look like I can update the ACPP version myself as I don't have repo perms, I think Aksel would need to do that? |
Anyone with write access to the repository can update ACPP version. If you specify the SHA of the ACPP commit you want to use, I can try to create a docker image with the ACPP compiler. |
|
I think I can do latest master - 65e010622e37b25d75b70d41776ebb2685b2e4a8. |
I've created #1138. If CI passes, I'll merge tomorrow. After that, you will need to update your branch with these changes (i.e. merge |
|
@carbotaniuman, I've updated the branch to test your changes and latest AdaptiveCPP emits errors. Please, take a look at the logs. |
|
@carbotaniuman - please remember to sign the CLA. Thanks for your contributions. |
|
@carbotaniuman Any news about this? |
|
Sorry, there were some issues revealed with my changes that I had to fix ACPP for, will update this and push a new version. |
carbotaniuman
force-pushed
the
update-acpp-bypasses
branch
from
e121acc to
f910782
Compare
|
Ok, pushed a new version, can I have acpp bumped to fcd26a61b600cd4b653724e59e72d4f7d1da259c to see if it works? |
I've created #1151. I'll merge it when CI passes. |
@carbotaniuman, unfortunately, the accp built from fcd26a61b600cd4b653724e59e72d4f7d1da259c still can't compile all enabled tests. In addition to that, there are some formatting issues with the pull request. Could you take a look please? |
This removes some ifdefs that are no longer needed while adding more fine-grained defines.
carbotaniuman
force-pushed
the
update-acpp-bypasses
branch
from
dca1aa7 to
4182bc9
Compare
|
@carbotaniuman, I would appreciate, if you use "merge" instead of "rebase" strategy to update your branch. |
|
WG approved to merge. |
6 participants
This removes several bypasses put in place for AdaptiveCpp. I'm not exactly sure what the contribution process is or how to edit the filter in the ci folder, so please let me know. I think these are best reviewed commit-by-commit.