Skip to content

vkcubepp: Refactor create_window and run functions #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 8, 2025
Merged

vkcubepp: Refactor create_window and run functions #1061

merged 2 commits into from
Apr 8, 2025

Conversation

water-chika
Copy link
Contributor

Use template parameter for WSI Platform to override create_window and run functions.

@ci-tester-lunarg
Copy link

Author water-chika not on autobuild list. Waiting for curator authorization before starting CI build.

3 similar comments
@ci-tester-lunarg
Copy link

Author water-chika not on autobuild list. Waiting for curator authorization before starting CI build.

@ci-tester-lunarg
Copy link

Author water-chika not on autobuild list. Waiting for curator authorization before starting CI build.

@ci-tester-lunarg
Copy link

Author water-chika not on autobuild list. Waiting for curator authorization before starting CI build.

@ci-tester-lunarg
Copy link

Author water-chika not on autobuild list. Waiting for curator authorization before starting CI build.

1 similar comment
@ci-tester-lunarg
Copy link

Author water-chika not on autobuild list. Waiting for curator authorization before starting CI build.

@CLAassistant
Copy link

CLAassistant commented Apr 7, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ci-tester-lunarg
Copy link

CI Vulkan-Tools build queued with queue ID 415850.

@ci-tester-lunarg
Copy link

CI Vulkan-Tools build # 1674 running.

charles-lunarg
charles-lunarg approved these changes Apr 7, 2025
View reviewed changes
Copy link
Contributor

@charles-lunarg charles-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the changes - apologies for the delay in reviewing them and getting them merged. I went ahead and rebased on main which added some fuchsia code that needed to be added to your abstractions.

@ci-tester-lunarg
Copy link

CI Vulkan-Tools build # 1674 passed.

@charles-lunarg charles-lunarg merged commit 555dca1 into KhronosGroup:main Apr 8, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charles-lunarg charles-lunarg charles-lunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@water-chika @ci-tester-lunarg @CLAassistant @charles-lunarg