ci: Utilize pre-installed Ninja #1109
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ninja is now available by default on all the runner images. The version of CMake provided by the runner images is always pretty new and gets updated frequently. The main benefits of lukka/get-cmake are: 1.) Test older version of cmake 2.) Get ninja and cache it. Reason 2 is now outdated for most of these checks. Removing it saves CI time & cache on runs that don't need it.
|
Author jpr42 not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author jpr42 not on autobuild list. Waiting for curator authorization before starting CI build. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ninja is now available by default on all the runner images.
The version of CMake provided by the runner images is always pretty new and gets updated frequently.
The main benefits of lukka/get-cmake are:
1.) Test older version of cmake
2.) Get ninja and cache it.
Reason 2 is now outdated for most of these checks.
Removing it saves CI time & cache on runs that don't need it.